Check DAO Method Return Type #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a basic code inspection feature that validates the return type of DAO methods and refactors the package structure of existing code inspection classes. Key changes include package renaming from common.sql.validator.result to common.validation.result, the addition of several new ValidationResult classes, and modifications in the PsiDaoMethod class.
Reviewed Changes
Copilot reviewed 71 out of 71 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/kotlin/org/domaframework/doma/intellij/contributor/sql/provider/SqlParameterCompletionProvider.kt | Updated import for ValidationCompleteResult. |
| src/main/kotlin/org/domaframework/doma/intellij/common/validation/result/* | Package name refactoring and new validation result implementations. |
| src/main/kotlin/org/domaframework/doma/intellij/common/util/ForDirectiveUtil.kt | Updated imports to match the new package structure. |
| src/main/kotlin/org/domaframework/doma/intellij/common/psi/PsiDaoMethod.kt | Updated sqlFileOption’s visibility from private to public. |
Comments suppressed due to low confidence (1)
src/main/kotlin/org/domaframework/doma/intellij/common/psi/PsiDaoMethod.kt:64
- Changing the visibility of sqlFileOption from private to public may expose internal state unintentionally. Consider using an accessor method if external access is needed or reverting to private to preserve encapsulation.
var sqlFileOption: Boolean = false
This was
linked to
issues
Jun 10, 2025
Closed
This was
unlinked from
issues
Jun 10, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a basic code inspection feature that checks the return type of DAO methods based on their annotation types.
Refactor the implementation of other code inspections and move the package of the class that returns the results of the code inspection feature.